Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix line-ending mismatch in CliDumperTest::testArray and CliDumperTest::testObject #54222

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

AhmedAlaa4611
Copy link
Contributor

Description
This PR resolves a platform-specific issue in the CliDumperTest::testArray and CliDumperTest::testObject test, where differences in line endings (\r\n vs. \n) between operating systems (Windows vs. Unix-based systems) caused the test to fail.

Problem
The test failed when running on systems with different line-ending.

Solution
Normalize line endings for both expected and actual output.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@taylorotwell taylorotwell merged commit ab0ee26 into laravel:11.x Jan 17, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants