Skip to content

[11.x] Don't overwrite custom replacements for count in trans_choice #53517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patrickrobrecht
Copy link
Contributor

Fixes #53516.

It also adds an additional unit test which fails without the bugfix.

@patrickrobrecht patrickrobrecht changed the title Don't overwrite custom replacements for count in trans_choice [11.x] Don't overwrite custom replacements for count in trans_choice Nov 14, 2024
patrickrobrecht and others added 2 commits November 14, 2024 15:55
@taylorotwell taylorotwell merged commit a20ca20 into laravel:11.x Nov 14, 2024
31 checks passed
@patrickrobrecht patrickrobrecht deleted the fix-53516-restore-bc-for-trans_choice branch November 14, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[11.x] trans_choice not backwards compatible when using custom replacements for count
2 participants