Skip to content

Fix schema foreign ID support for tables with non-standard primary key #53442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2024
Merged

Fix schema foreign ID support for tables with non-standard primary key #53442

merged 5 commits into from
Nov 8, 2024
+54 −4

Conversation

willrowe
Copy link
Contributor

@willrowe willrowe commented Nov 7, 2024

This allows foreignIdFor to automatically set the referenced column name for tables/models with non-standard primary key names.

willrowe and others added 5 commits November 7, 2024 18:13
@willrowe
Add test for constrained foreign keys
Loading
Loading status checks…
5dce30b
@willrowe
Add failing test
Loading
Loading status checks…
91be0e1
@willrowe
Set the referenced column name based on the model key name
b19eac2
@willrowe
Use the referenced column name if available
dc96c24
@taylorotwell
formatting

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
528126b
@taylorotwell taylorotwell merged commit 71dfdc0 into laravel:11.x Nov 8, 2024
31 checks passed
@willrowe willrowe deleted the hotfix/constrained-primary-key branch November 8, 2024 14:23
@blumilk-renovate blumilk-renovate bot mentioned this pull request Dec 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willrowe @taylorotwell