[10.x] Make the firstOrCreate methods in relations use createOrFirst behind the scenes
#48192
+37
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be the same but more robust, since it handles race conditions as well
This should essentially be the same as before, but more robust
tonysm
changed the title
createOrFirst in relationsfirstOrCreate methods in relations use createOrFirst behind the scenes
mpyw
added a commit
to mpyw/framework
that referenced
this pull request
Aug 28, 2023
…hind the scenes Related to laravel#48160, laravel#48192
mpyw
added a commit
to mpyw/framework
that referenced
this pull request
Aug 28, 2023
mpyw
added a commit
to mpyw/framework
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
createOrFirstmethod to Eloquent #47973, I only switched theBuilder::firstOrCreateto also use thecreateOrFirstbehind to scenes and missed theBelongsToMany::firstOrCreateandHasOneOrMany::firstOrCreate. This PR also changes the missed methods to usefirstOrCreateinstead of simply trying tocreaterelated records after not finding them, also solving the race condition issue in the relations.BelongsToMany::firstOrCreatein a SAVEPOINT if needed and atry/catchto handle the unique violation there as well, making it more robustHat tip to @mpyw for pointing out that I missed those methods in the original implementation.