-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0] Major package upgrades, better TypeScript support, smaller build #413
[2.0] Major package upgrades, better TypeScript support, smaller build #413
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
return new NullChannel(); | ||
} | ||
|
||
/** | ||
* Get a channel instance by name. | ||
*/ | ||
channel(name: string): NullChannel { | ||
channel(_name: string): NullChannel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these need to be renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tells ESlint that it's an unused argument
Thanks @SanderMuller! |
@SanderMuller Thanks for doing this! |
This PR modernizing the library with upgraded dependencies, enhanced TypeScript support, and improved compatibility with modern Node.js environments.
Key Changes
Node.js Version Upgrade:
TypeScript Enhancements:
Dependency Upgrades:
glob
.vue
,axios
,jquery
, and@hotwired/turbo
are not bundled.Modernized Build Process:
Developer Experience Improvements:
Breaking Changes (Contributor only)
Node.js Requirement (Contributor only):
20+
.dist/
) are unaffected.TypeScript Compatibility (Contributor only):
ESLint Config (Contributor only):
Benefits
glob
have been updated to secure versions as well as Eslint major upgrade.Testing done
Pusher
andReverb
setup locally in two big projects leveraging websockets. Both using Webpack with Laravel Mix.