[1.x] Fix IIFE build #344
Merged
[1.x] Fix IIFE build #344
+34
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #343, the IIFE functionality had a breaking change recently that saw the usage of
window.Echobreak. The manual fix was to start referencingwindow.Echo.default.This break was caused by the additional exports from echo to improve the packages usage within Typescript packages, which I believe in theory is a good idea.
This PR introduces an additional build config for the IIFE version which allows us to only export the Echo class, thus returning to the original
window.Echofunctionality for IIFE usage.