Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update report parameter in rescue stub to match laravel #1911

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

carlalexander
Copy link
Contributor

This updates the rescue function report parameter. It supports both bool and callable.

@calebdw
Copy link
Contributor

calebdw commented Apr 12, 2024

If the framework has proper generics now then the stub for this method can just be removed

@carlalexander
Copy link
Contributor Author

Updated the PR! Thanks for taking a look!

@calebdw
Copy link
Contributor

calebdw commented Apr 12, 2024

Hmm it looks like it's still needed for Laravel 9 ☹️---we'll have to wait to remove this until v3

@szepeviktor
Copy link
Collaborator

The problem is that this file is for Laravel v9, v10, v11 but the improved docblock is only in v11.

@carlalexander
Copy link
Contributor Author

Well, my original change was consistent with laravel 9. report accepts bool|callable.

@szepeviktor
Copy link
Collaborator

L10 has no generics, L9 has no nothing

     * @param  callable  $callback
     * @param  mixed  $rescue
     * @param  bool|callable  $report
     * @return mixed

@calebdw
Copy link
Contributor

calebdw commented Apr 12, 2024

Yeah, that works, sorry about the run around!

@carlalexander
Copy link
Contributor Author

No worries!

@canvural canvural merged commit 3e7b121 into larastan:2.x Apr 14, 2024
35 checks passed
@canvural
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants