Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redis get return type #1906

Merged
merged 1 commit into from
Apr 6, 2024
Merged

fix: redis get return type #1906

merged 1 commit into from
Apr 6, 2024

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Apr 6, 2024

Hello!

This should fix the ci, see phpstan/phpstan-src#2990 for reference.

Thanks!

@szepeviktor
Copy link
Collaborator

szepeviktor commented Apr 6, 2024 •
edited

Thank you Caleb.

Do you know the reason for this change?

@calebdw
Copy link
Contributor Author

calebdw commented Apr 6, 2024 •
edited

It looks like the redis get could return other data types besides just a string. That pr solved another issues on the phpstan side

@szepeviktor szepeviktor merged commit 20d7c9d into larastan:2.x Apr 6, 2024
35 checks passed
@calebdw calebdw deleted the fix_ci branch April 6, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calebdw @szepeviktor