fix: float not assignable to decimal cast #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
reviewed
Mar 8, 2024
| 'decimal' => TypeCombinator::intersect(new StringType(), new AccessoryNumericStringType()), | ||
| 'decimal' => TypeCombinator::intersect(new StringType(), new AccessoryNumericStringType(), new FloatType()), |
There was a problem hiding this comment.
This is the real change.
|
Adding just the float is right here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1869
Changes
Hello!
This PR updates the Eloquent
decimalwritable type to acceptfloat.I also tried to cleanup the file a bit by using the
::classconstant instead of the entire raw class string, but feel free to pop that off if you don't like it.Thanks!