Uses @template-covariant in collections

[Grldk]

• Added or updated tests
• Documented user facing changes

Changes

Changes Collection TValue from @template to @template-covariant

see, laravel/framework#46872

I am not sure if this change needs added tests. All existing tests pass.

[Grldk]

Adding @template-covariant in EloquentBuilder.stub would solve a number of problems for me as well. Should I create a separate PR for that, or can I add that to this one?

[szepeviktor]

It would be nice to fix unit tests here.

[Grldk]

Hmm, all tests passed for me locally, so to be honest I didn't really pay any attention to the test results here..

I'll try to fix the unit tests soon, hopefully tomorrow or else early next week.

[Grldk]

Well, I guess those tests will not pass: phpstan/phpstan#9590

Not sure what to do with this now. We'll have to wait for call-site variance in phpstan I guess..

[mad-briller]

phpstan/phpstan-src#2485 (review) i believe it's already in the works thanks to this pr

[canvural]

Hi,

This is just wrong 😄 And the decision that Laravel defined the templates as covariant is also wrong. Now I'm happy that Larastan overrides that info!

With template-covariant basically there'd be no guarantee that Collection<int, User> would only contain Users, in the type system level.

This is how Doctrine collections also have their annotations. Also any mutable collection implementations.

So, as long as the Laravel collections are mutable this will not happen. Hope it's clear.