Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suggested questions language #4269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YidaHu
Copy link
Contributor

@YidaHu YidaHu commented May 10, 2024

Description

This PR introduces the ability to specify the language for generating suggested questions based on the app settings. Previously, the language was not specified. Now, the language can be set according to the app's settings, providing a more personalized and accurate generation of suggested questions for different language users.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working 💪 enhancement New feature or request labels May 10, 2024
@leslie2046
Copy link
Contributor

Maybe sometimes the suggested questions language should follow the language from user inputs in multilingal?
Sometimes we cannot set a language to a certain fixed language i think。

@YidaHu
Copy link
Contributor Author

YidaHu commented May 11, 2024

Maybe sometimes the suggested questions language should follow the language from user inputs in multilingal? Sometimes we cannot set a language to a certain fixed language i think。

@leslie2046 You're right. Then I think prompt should be modified so that the LLM can give the corresponding language suggestions based on the context language. Not according to the set language.

@takatost
Copy link
Collaborator

Since the default strategy is not specifically for English, but for all languages, sometimes there may be some issues with language understanding.
I suggest reverting the default strategy back to its original state here, and if a specific language is passed in, then add the corresponding prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💪 enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants