Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openai): include model_name in response_metadata #7403

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

anadi45
Copy link
Contributor

@anadi45 anadi45 commented Dec 18, 2024

Resolved the issue where the model_name field was absent in the response_metadata of the JavaScript SDK for ChatOpenAI, aligning it with the Python SDK's behavior.

Fixes Issue

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Dec 18, 2024 8:37pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Dec 18, 2024 8:37pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 18, 2024
@anadi45 anadi45 changed the title fix: include model_name in response_metadata fix(openai): include model_name in response_metadata Dec 18, 2024
@anadi45
Copy link
Contributor Author

anadi45 commented Dec 18, 2024

@jacoblee93 Please take a look whenever you get time.

…gchainjs into fix-openai-response-metadata
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Dec 20, 2024
@jacoblee93 jacoblee93 merged commit 62bcabd into langchain-ai:main Dec 20, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants