fix(cohere,langchain): handle exceptions in compressDocuments and formatDocuments methods due to empty documents #7372
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts if the documents parameter is null or empty
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:bug
ahm750
changed the title
jacoblee93
reviewed
Dec 16, 2024
jacoblee93
reviewed
Dec 16, 2024
|
@jacoblee93 applied the changes you requested. |
|
Can you ensure this fix is included in the next release? We're unable to use the Cohere reranker due to this bug. |
jacoblee93
changed the title
|
Hey apologies for the delay! Will aim to get it out tonight |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7370
Prevent the
invalid request: list of documents must not be emptyerror caused bycompressDocumentsmethod due todocumentsbeing empty. Added a condition to check ifdocumentsis empty. If yes, return an empty array.Prevent exception thrown from
formattedDocsmethods whendocumentsis empty. Added a condition to check ifdocumentsis empty. If yes, return an empty string.