Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(community): Fix logic issue #7151

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

clemenspeters
Copy link
Contributor

The ?? operator is the nullish coalescing operator, which only checks for null or undefined. However, the expression before it getEnvironmentVariable("LANGCHAIN_VERBOSE") === "true" is a boolean expression and will never be null or undefined.

@PetersClemens

Fixes # (issue)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 5, 2024
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 5, 2024 7:38pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 5, 2024 7:38pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Nov 5, 2024
@jacoblee93 jacoblee93 changed the title Fix logic issue fix(community): Fix logic issue Nov 5, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Nov 5, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

WHERE ${collectionId ? "collection_id = $2 AND " : ""}${
this.idColumnName
} = ANY($1::uuid[])
WHERE ${collectionId ? "collection_id = $2 AND " : ""}${this.idColumnName
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run yarn format? Seems like it's blocking CI

I don't have permission to merge to your branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! I ran it on the wrong branch before 🙈

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
@jacoblee93 jacoblee93 merged commit 7102edd into langchain-ai:main Nov 5, 2024
32 checks passed
cinqisap pushed a commit to cinqisap/langchainjs that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants