community[minor]: Improve Azure AI Search vector store support #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -456,9 +441,6 @@ describe.skip("AzureAISearchVectorStore integration tests", () => { | |||
|
|
|||
| const store = new AzureAISearchVectorStore(embeddings, { | |||
| indexName: INDEX_NAME, | |||
| search: { | |||
| type: AzureAISearchQueryType.Similarity, | |||
| }, | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Hey there! 👋 I've reviewed the code and noticed that the added test case explicitly accesses an environment variable via process.env. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Keep up the great work! 🚀
|
Seems reasonable, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the existing Azure Cosmos DB vector store in the following ways: