-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community[minor]: add neon postgres as a vector store #5152
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,92 @@ | |||
import { OpenAIEmbeddings } from "@langchain/openai"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the PR! I've flagged this change for maintainers to review as it explicitly accesses environment variables using process.env
. This is an important security consideration, so it's good to have a thorough review of this code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just example code, not an actual application
@@ -76,6 +76,7 @@ | |||
"@jest/globals": "^29.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that this PR adds a new hard dependency, "@neondatabase/serverless", to the project. I've flagged this for your review to ensure it aligns with our project's dependencies. Keep up the great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added only as a dev dependency
@@ -0,0 +1,357 @@ | |||
import { neon } from "@neondatabase/serverless"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the PR! I've flagged a specific change for the maintainers to review, as it involves accessing an environment variable using the getEnvironmentVariable
function. Keep up the good work!
This looks great! Thank you! |
This PR adds Neon Postgres (backed by the pgvector extension) as a vector store. The code mostly follows the vercel-postgres integration but uses the Neon database serverless driver (https://github.com/neondatabase/serverless), which is quicker for one-shot queries.
(I write technical content for Neon)