Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-genai[patch]: update google/generative-ai version #5115

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

HenryHengZJ
Copy link
Contributor

@HenryHengZJ HenryHengZJ commented Apr 16, 2024

Fixes #5070
Allow gemini-1.5-pro-latest to be usable using latest google/generative-ai version

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 16, 2024
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 7:58pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 22, 2024 7:58pm

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Apr 16, 2024
@@ -39,7 +39,7 @@
"author": "LangChain",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed the update to the "@google/generative-ai" dependency in the package.json file, which seems to be a change in the peer dependency. I've flagged this for your review to ensure it aligns with the project's requirements. Keep up the great work!

@HenryHengZJ
Copy link
Contributor Author

@jacoblee93 in the latest google/gen-ai version, the underlying API is changed to v1beta, see PR

I couldn't get yarn.lock working properly with the latest version, would you be able to help with updating that?

@afirstenberg
Copy link
Contributor

See also #5070
Although the package makes the apiVersion "v1beta", it would be good to take this opportunity to add it for the model attribute.

@afirstenberg
Copy link
Contributor

I think the changes here are pretty modest, and certainly good to get the library that supports Gemini 1.5 in is useful.
This is a prerequisite for all of the other new features (at least in the google-genai package).

@HenryHengZJ
Copy link
Contributor Author

See also #5070 Although the package makes the apiVersion "v1beta", it would be good to take this opportunity to add it for the model attribute.

what do you mean by the model attribute?

@afirstenberg
Copy link
Contributor

See also #5070 Although the package makes the apiVersion "v1beta", it would be good to take this opportunity to add it for the model attribute.

what do you mean by the model attribute?

Yeah, that was a bit confusing on my part. Sorry.

What I meant to say is that it would be a good idea to add it as a attribute anywhere that "modelName" is also an attribute, with a way to set it anywhere that "modelName" can be set.

@afirstenberg
Copy link
Contributor

I would have still liked to see support for an apiVersion parameter, but at this point I think it should just be released ASAP. (@jacoblee93, @bracesproul)

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google-genai [feature]: Support apiVersion
3 participants