Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely less on positional arg order in subclasses of vector store when calling async methods #8534

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

nfcampos
Copy link
Collaborator

No description provided.

@nfcampos nfcampos requested a review from hwchase17 July 31, 2023 18:56
@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 31, 2023 6:56pm

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:improvement Medium size change to existing code to handle new use-cases labels Jul 31, 2023
@nfcampos nfcampos merged commit 4780156 into master Jul 31, 2023
@nfcampos nfcampos deleted the nc/fix-vectorstore-pos-args branch July 31, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants