core[major]: AsyncCallbackManagerForToolRun no longer casts return object to string

[adreo00]

• Description: Stops AsyncCallbackManagerForToolRun from converting the output to str
• Issue: AsyncCallbackManagerForToolRun improperly casts on_tool_end to string #20372
• Dependencies: None

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchain	⬜️ Ignored (Inspect)	Visit Preview		Apr 17, 2024 10:46pm

[adreo00]

This output=str(output) occurs in a few other places: https://github.com/search?q=repo%3Alangchain-ai%2Flangchain%20%22output%20%3D%20str(output)%22&type=code

The only other spot it occurs in langchain_core though, is when it's printed, not returned, so I assume that's fine. The rest are in langchain_community, and I'm limiting this PR to one langchain package, as requested.

[adreo00]

Due to this being an async callback, I'm not sure how I could add tests to this code, but am open to suggestions. Issue #20372 is able to reproduce this issue, but is not minimal enough to be included as a unit test.

[adreo00]

@eyurtsev I'm sure you're slammed with other issues, but any chance you could take a look at this considering how close this PR is to the one you and @keenborder786 authored: #18932

[eyurtsev]

Going to verify a few traces to make sure this doesn't break anything, and if so we can release as part of 0.2 release.

[eyurtsev]

cc @baskaryan

[eyurtsev]

Will be released as part of 0.2.x