-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
core[patch]: include tool_calls in ai msg chunk serialization #20291
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
from langchain_core.load import dumpd, load | ||
from langchain_core.messages import ( | ||
AIMessage, | ||
AIMessageChunk, | ||
InvalidToolCall, | ||
ToolCall, | ||
ToolCallChunk, | ||
) | ||
|
||
|
||
def test_serdes_message() -> None: | ||
msg = AIMessage( | ||
content=[{"text": "blah", "type": "text"}], | ||
tool_calls=[ToolCall(name="foo", args={"bar": 1}, id="baz")], | ||
invalid_tool_calls=[ | ||
InvalidToolCall(name="foobad", args="blah", id="booz", error="bad") | ||
], | ||
) | ||
expected = { | ||
"lc": 1, | ||
"type": "constructor", | ||
"id": ["langchain", "schema", "messages", "AIMessage"], | ||
"kwargs": { | ||
"content": [{"text": "blah", "type": "text"}], | ||
"tool_calls": [{"name": "foo", "args": {"bar": 1}, "id": "baz"}], | ||
"invalid_tool_calls": [ | ||
{"name": "foobad", "args": "blah", "id": "booz", "error": "bad"} | ||
], | ||
}, | ||
} | ||
actual = dumpd(msg) | ||
assert actual == expected | ||
assert load(actual) == msg | ||
|
||
|
||
def test_serdes_message_chunk() -> None: | ||
chunk = AIMessageChunk( | ||
content=[{"text": "blah", "type": "text"}], | ||
tool_call_chunks=[ | ||
ToolCallChunk(name="foo", args='{"bar": 1}', id="baz", index=0), | ||
ToolCallChunk(name="foobad", args="blah", id="booz", index=1), | ||
], | ||
) | ||
expected = { | ||
"lc": 1, | ||
"type": "constructor", | ||
"id": ["langchain", "schema", "messages", "AIMessageChunk"], | ||
"kwargs": { | ||
"content": [{"text": "blah", "type": "text"}], | ||
"tool_calls": [{"name": "foo", "args": {"bar": 1}, "id": "baz"}], | ||
"invalid_tool_calls": [ | ||
{ | ||
"name": "foobad", | ||
"args": "blah", | ||
"id": "booz", | ||
"error": "Malformed args.", | ||
} | ||
], | ||
"tool_call_chunks": [ | ||
{"name": "foo", "args": '{"bar": 1}', "id": "baz", "index": 0}, | ||
{"name": "foobad", "args": "blah", "id": "booz", "index": 1}, | ||
], | ||
}, | ||
} | ||
actual = dumpd(chunk) | ||
assert actual == expected | ||
assert load(actual) == chunk |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are
tool_call_chunks
serialized properly without being in here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default behavior is to serialize (only) attributes that are passed in as init args