-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain: allow CacheBackedEmbeddings to cache queries #20073
Merged
eyurtsev
merged 8 commits into
langchain-ai:master
from
jokester:allow-cache-backed-embeddings-query
May 13, 2024
Merged
langchain: allow CacheBackedEmbeddings to cache queries #20073
eyurtsev
merged 8 commits into
langchain-ai:master
from
jokester:allow-cache-backed-embeddings-query
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jokester
force-pushed
the
allow-cache-backed-embeddings-query
branch
from
April 7, 2024 15:30
2b44ff3
to
22f241d
Compare
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
Ɑ: embeddings
Related to text embedding models module
🤖:improvement
Medium size change to existing code to handle new use-cases
labels
Apr 7, 2024
jokester
force-pushed
the
allow-cache-backed-embeddings-query
branch
from
April 7, 2024 15:40
334a032
to
e9b2423
Compare
jokester
changed the title
langchain: allow CacheBackedEmbeddingsallow to cache query embeddings
langchain: allow CacheBackedEmbeddings to cache queries
Apr 7, 2024
@eyurtsev Sorry to bother but can I ask you to review this too? 🙏🏽 I think this PR answers some concern in previous code comments and also make it easier to use. |
jokester
force-pushed
the
allow-cache-backed-embeddings-query
branch
from
April 11, 2024 11:16
bbea91b
to
b753d85
Compare
jokester
force-pushed
the
allow-cache-backed-embeddings-query
branch
from
April 19, 2024 08:10
b753d85
to
348ffa8
Compare
jokester
force-pushed
the
allow-cache-backed-embeddings-query
branch
from
April 26, 2024 09:48
348ffa8
to
da4aaa7
Compare
jokester
force-pushed
the
allow-cache-backed-embeddings-query
branch
from
May 6, 2024 17:04
da4aaa7
to
349c07a
Compare
eyurtsev
approved these changes
May 13, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
May 13, 2024
Looks great! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ɑ: embeddings
Related to text embedding models module
🤖:improvement
Medium size change to existing code to handle new use-cases
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
PR title: "package: description"
Description:
This PR allow cache of query embedding. Prior to this PR, it required a custom class to cache queries too.
To make the change non-breaking, query caching is not enabled by default.
Issue: no, but an intent was mentioned in docs: mention caveats with CacheBackedEmbeddings.embed_query #19926
Dependencies: no
**Twitter handle:
tarsylia
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrations
directory.Lint and test: Run
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.