Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community:Modified regular expression #19449

Merged
merged 2 commits into from
Mar 22, 2024
Merged

community:Modified regular expression #19449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13175b1
modified regular expression to add support for unicode chars and simp…
igeni Mar 22, 2024
caf2f43
Merge branch 'master' into regexp-fix
baskaryan Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/cli/langchain_cli/utils/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def _get_repo_path(gitstring: str, ref: Optional[str], repo_dir: Path) -> Path:
removed_protocol = gitstring.split("://")[-1]
removed_basename = re.split(r"[/:]", removed_protocol, 1)[-1]
removed_extras = removed_basename.split("#")[0]
foldername = re.sub(r"[^a-zA-Z0-9_]", "_", removed_extras)
foldername = re.sub(r"\W", "_", removed_extras)

directory_name = f"{foldername}_{hashed}"
return repo_dir / directory_name
Expand Down