community: add request_timeout and max_retries to BaseCohere #19346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mspronesti
reviewed
Mar 20, 2024
Co-authored-by: Massimiliano Pronesti <massimiliano.pronesti@gmail.com>
|
Thanks for accepting my suggestion :) Looks good to me! |
|
Opened #19641 to port this changes to the newer package |
baskaryan
added a commit
that referenced
this pull request
Apr 1, 2024
As in #19346, this PR exposes `request_timeout` in `BaseCohere`, while `max_retires` is no longer a parameter of the beneath client (`cohere.Client`) and it is already configured in `langchain_cohere.llms.Cohere`. --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
marlenezw
pushed a commit
to marlenezw/langchain
that referenced
this pull request
Apr 2, 2024
) As in langchain-ai#19346, this PR exposes `request_timeout` in `BaseCohere`, while `max_retires` is no longer a parameter of the beneath client (`cohere.Client`) and it is already configured in `langchain_cohere.llms.Cohere`. --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
As in #19346, this PR exposes `request_timeout` in `BaseCohere`, while `max_retires` is no longer a parameter of the beneath client (`cohere.Client`) and it is already configured in `langchain_cohere.llms.Cohere`. --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make
request_timeoutandmax_retriesconfigurable for Cohere.