Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langchain: upgrade mypy #19163

Merged
merged 9 commits into from Mar 15, 2024
Merged

langchain: upgrade mypy #19163

merged 9 commits into from Mar 15, 2024

Conversation

eyurtsev
Copy link
Collaborator

Update mypy in langchain

@vercel Vercel
Copy link

vercel bot commented Mar 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 7:20pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: agent Related to agents module 🔌: openai Primarily related to OpenAI integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 15, 2024
efriis
efriis reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can get tests passing I'm all for it but I can't even get a lot of the partner packages passing on mypy^1 because of pydantic v1 stub

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 15, 2024
@eyurtsev eyurtsev merged commit 745d247 into master Mar 15, 2024
41 checks passed
@eyurtsev eyurtsev deleted the mypy branch March 15, 2024 20:37
@baskaryan baskaryan mentioned this pull request Mar 15, 2024
Closed
1 task
rahul-trip pushed a commit to daxa-ai/langchain that referenced this pull request Mar 27, 2024
@eyurtsev @rahul-trip
langchain: upgrade mypy (langchain-ai#19163)
81f9006 
Update mypy in langchain
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
@eyurtsev
langchain: upgrade mypy (langchain-ai#19163)
ff4c974 
Update mypy in langchain
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@eyurtsev @gkorland
langchain: upgrade mypy (langchain-ai#19163)
9de9d2c 
Update mypy in langchain
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@eyurtsev @hinthornw
langchain: upgrade mypy (#19163)
dc7c669 
Update mypy in langchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis left review comments

@baskaryan baskaryan baskaryan approved these changes

Assignees

@efriis efriis

Labels
Ɑ: agent Related to agents module 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: openai Primarily related to OpenAI integrations size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eyurtsev @efriis @baskaryan