Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: implement qdrant _aembed_query and use it in other async funcs #19155

Merged
merged 2 commits into from Mar 15, 2024

Conversation

kaijietti
Copy link
Contributor

amax_marginal_relevance_search and asimilarity_search_with_score should use an async version of _embed_query .

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 7:37pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 15, 2024
@kaijietti
Copy link
Contributor Author

@baskaryan Can you help me with the workflows here. Please approve the workflows and I can ensure the all tests are passing.

@kaijietti
Copy link
Contributor Author

@efriis Can you help me with the workflows here. Please approve the workflows and I can ensure the all tests are passing.

Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 15, 2024
Copy link
Contributor

@kacperlukawski kacperlukawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baskaryan baskaryan enabled auto-merge (squash) March 15, 2024 21:14
@baskaryan baskaryan merged commit c20aeef into langchain-ai:master Mar 15, 2024
58 checks passed
rahul-trip pushed a commit to daxa-ai/langchain that referenced this pull request Mar 27, 2024
…async funcs (langchain-ai#19155)

`amax_marginal_relevance_search ` and `asimilarity_search_with_score `
should use an async version of `_embed_query `.
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
…async funcs (langchain-ai#19155)

`amax_marginal_relevance_search ` and `asimilarity_search_with_score `
should use an async version of `_embed_query `.
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
…async funcs (langchain-ai#19155)

`amax_marginal_relevance_search ` and `asimilarity_search_with_score `
should use an async version of `_embed_query `.
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
…async funcs (#19155)

`amax_marginal_relevance_search ` and `asimilarity_search_with_score `
should use an async version of `_embed_query `.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants