community: Add support for cohere SDK v5 (keeps v4 backwards compatibility) #19084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
billytrend-cohere
commented
Mar 14, 2024
•
billytrend-cohere
commented
- Description: Add support for cohere SDK v5 (keeps v4 backwards compatibility)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
billytrend-cohere
changed the title
dosubot
bot
added
size:L
efriis
approved these changes
Mar 14, 2024
| @@ -34,7 +36,7 @@ class CohereEmbeddings(BaseModel, Embeddings): | |||
|
|
|||
| cohere_api_key: Optional[str] = None | |||
|
|
|||
| max_retries: Optional[int] = 3 | |||
| max_retries: int = 3 | |||
There was a problem hiding this comment.
Will technically break anyone explicitly passing max_retries=None, which may be something people were using instead of max_retries=0. If that wouldn't work before though, I like this as it's more explicit!
There was a problem hiding this comment.
Ah actually looks like old behavior would do something unpredictable because would "fall back on other params to urllib3.Retry" but there were no other params. This is a good change.
dosubot
bot
added
the
lgtm
billytrend-cohere
added a commit
to billytrend-cohere/langchain
that referenced
this pull request
Mar 20, 2024
rahul-trip
pushed a commit
to daxa-ai/langchain
that referenced
this pull request
Mar 27, 2024
…ility) (langchain-ai#19084) - **Description:** Add support for cohere SDK v5 (keeps v4 backwards compatibility) --------- Co-authored-by: Erick Friis <erick@langchain.dev>
bechbd
pushed a commit
to bechbd/langchain
that referenced
this pull request
Mar 29, 2024
…ility) (langchain-ai#19084) - **Description:** Add support for cohere SDK v5 (keeps v4 backwards compatibility) --------- Co-authored-by: Erick Friis <erick@langchain.dev>
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…ility) (langchain-ai#19084) - **Description:** Add support for cohere SDK v5 (keeps v4 backwards compatibility) --------- Co-authored-by: Erick Friis <erick@langchain.dev>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…ility) (#19084) - **Description:** Add support for cohere SDK v5 (keeps v4 backwards compatibility) --------- Co-authored-by: Erick Friis <erick@langchain.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.