community[patch]: Fix NotionDBLoader 400 Error by conditionally adding filter parameter #19075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gunnzolder
commented
Mar 14, 2024
gunnzolder
commented
- Description: This change fixes a bug where attempts to load data from Notion using the NotionDBLoader resulted in a 400 Bad Request error. The issue was traced to the unconditional addition of an empty 'filter' object in the request payload, which Notion's API does not accept. The modification ensures that the 'filter' object is only included in the payload when it is explicitly provided and not empty, thus preventing the 400 error from occurring.
- Issue: Fixes #18009
- Dependencies: None
- Twitter handle: @gunnzolder
Modified _request method in langchain/libs/community/langchain_community/document_loaders/notiondb.py to conditionally include the 'filter' key in the JSON payload only if the filter_object is provided and not empty. Related GitHub Issue: langchain-ai#18009
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
eyurtsev
approved these changes
Mar 14, 2024
dosubot
bot
added
the
lgtm
eyurtsev
changed the title
rahul-trip
pushed a commit
to daxa-ai/langchain
that referenced
this pull request
Mar 27, 2024
…g filter parameter (langchain-ai#19075) - **Description:** This change fixes a bug where attempts to load data from Notion using the NotionDBLoader resulted in a 400 Bad Request error. The issue was traced to the unconditional addition of an empty 'filter' object in the request payload, which Notion's API does not accept. The modification ensures that the 'filter' object is only included in the payload when it is explicitly provided and not empty, thus preventing the 400 error from occurring. - **Issue:** Fixes [langchain-ai#18009](langchain-ai#18009) - **Dependencies:** None - **Twitter handle:** @gunnzolder Co-authored-by: Anton Parkhomenko <anton@merge.rocks>
bechbd
pushed a commit
to bechbd/langchain
that referenced
this pull request
Mar 29, 2024
…g filter parameter (langchain-ai#19075) - **Description:** This change fixes a bug where attempts to load data from Notion using the NotionDBLoader resulted in a 400 Bad Request error. The issue was traced to the unconditional addition of an empty 'filter' object in the request payload, which Notion's API does not accept. The modification ensures that the 'filter' object is only included in the payload when it is explicitly provided and not empty, thus preventing the 400 error from occurring. - **Issue:** Fixes [langchain-ai#18009](langchain-ai#18009) - **Dependencies:** None - **Twitter handle:** @gunnzolder Co-authored-by: Anton Parkhomenko <anton@merge.rocks>
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…g filter parameter (langchain-ai#19075) - **Description:** This change fixes a bug where attempts to load data from Notion using the NotionDBLoader resulted in a 400 Bad Request error. The issue was traced to the unconditional addition of an empty 'filter' object in the request payload, which Notion's API does not accept. The modification ensures that the 'filter' object is only included in the payload when it is explicitly provided and not empty, thus preventing the 400 error from occurring. - **Issue:** Fixes [langchain-ai#18009](langchain-ai#18009) - **Dependencies:** None - **Twitter handle:** @gunnzolder Co-authored-by: Anton Parkhomenko <anton@merge.rocks>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…g filter parameter (#19075) - **Description:** This change fixes a bug where attempts to load data from Notion using the NotionDBLoader resulted in a 400 Bad Request error. The issue was traced to the unconditional addition of an empty 'filter' object in the request payload, which Notion's API does not accept. The modification ensures that the 'filter' object is only included in the payload when it is explicitly provided and not empty, thus preventing the 400 error from occurring. - **Issue:** Fixes [#18009](#18009) - **Dependencies:** None - **Twitter handle:** @gunnzolder Co-authored-by: Anton Parkhomenko <anton@merge.rocks>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.