core: Runnable pass kwargs to _astream_log_implementation in astream_log #19055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:XS
eyurtsev
approved these changes
Mar 14, 2024
dosubot
bot
added
the
lgtm
|
thank you! |
rahul-trip
pushed a commit
to daxa-ai/langchain
that referenced
this pull request
Mar 27, 2024
…log (langchain-ai#19055) - **Description:** When calling the `_stream_log_implementation` from the `astream_log` method in the `Runnable` class, it is not handing over the `kwargs` argument. Therefore, even if i want to customize APIHandler and implement additional features with additional arguments, it is not possible. Conversely, the `astream_events` method normally handing over the `kwargs` argument. - **Issue:** langchain-ai#19054 - **Dependencies:** - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
bechbd
pushed a commit
to bechbd/langchain
that referenced
this pull request
Mar 29, 2024
…log (langchain-ai#19055) - **Description:** When calling the `_stream_log_implementation` from the `astream_log` method in the `Runnable` class, it is not handing over the `kwargs` argument. Therefore, even if i want to customize APIHandler and implement additional features with additional arguments, it is not possible. Conversely, the `astream_events` method normally handing over the `kwargs` argument. - **Issue:** langchain-ai#19054 - **Dependencies:** - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…log (langchain-ai#19055) - **Description:** When calling the `_stream_log_implementation` from the `astream_log` method in the `Runnable` class, it is not handing over the `kwargs` argument. Therefore, even if i want to customize APIHandler and implement additional features with additional arguments, it is not possible. Conversely, the `astream_events` method normally handing over the `kwargs` argument. - **Issue:** langchain-ai#19054 - **Dependencies:** - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
…log (#19055) - **Description:** When calling the `_stream_log_implementation` from the `astream_log` method in the `Runnable` class, it is not handing over the `kwargs` argument. Therefore, even if i want to customize APIHandler and implement additional features with additional arguments, it is not possible. Conversely, the `astream_events` method normally handing over the `kwargs` argument. - **Issue:** #19054 - **Dependencies:** - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_stream_log_implementationfrom theastream_logmethod in theRunnableclass, it is not handing over thekwargsargument. Therefore, even if i want to customize APIHandler and implement additional features with additional arguments, it is not possible. Conversely, theastream_eventsmethod normally handing over thekwargsargument.