Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain_ibm[patch] add async tests, add tokenize support #18898

Merged
merged 8 commits into from Mar 14, 2024

Conversation

MateuszOssGit
Copy link
Contributor

@MateuszOssGit MateuszOssGit commented Mar 11, 2024

  • Description: add async tests, add tokenize support
  • Dependencies: ibm-watsonx-ai,
  • Tag maintainer:

Please make sure your PR is passing linting and testing before submitting. Run make format, make lint and make test to check this locally -> ✅
Please make sure integration_tests passing locally -> ✅

@efriis efriis added the partner label Mar 11, 2024
@efriis efriis self-assigned this Mar 11, 2024
Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 10:55pm

@MateuszOssGit MateuszOssGit marked this pull request as ready for review March 11, 2024 10:24
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: models Related to LLMs or chat model modules 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 11, 2024
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default implementation of the async method already proxies sync using a threadpool.

Overriding of _agenerate is reserved for async native implementations; i.e., without having to rely on a thread

@MateuszOssGit MateuszOssGit changed the title langchain_ibm[patch] add _agenerate method, add async tests langchain_ibm[patch] add async tests Mar 11, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 11, 2024
@MateuszOssGit MateuszOssGit marked this pull request as draft March 11, 2024 15:15
@MateuszOssGit MateuszOssGit changed the title langchain_ibm[patch] add async tests langchain_ibm[patch] add async tests, add tokenize support Mar 12, 2024
@MateuszOssGit MateuszOssGit marked this pull request as ready for review March 13, 2024 13:59
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
@MateuszOssGit
Copy link
Contributor Author

@eyurtsev I removed _agenerate implementation. Could you pls review again?

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 14, 2024
@efriis efriis enabled auto-merge (squash) March 14, 2024 22:55
@efriis efriis merged commit b15d150 into langchain-ai:master Mar 14, 2024
20 checks passed
rahul-trip pushed a commit to daxa-ai/langchain that referenced this pull request Mar 27, 2024
- **Description:** add async tests, add tokenize support
- **Dependencies:**
[ibm-watsonx-ai](https://pypi.org/project/ibm-watsonx-ai/),
  - **Tag maintainer:** 

Please make sure your PR is passing linting and testing before
submitting. Run `make format`, `make lint` and `make test` to check this
locally -> ✅
Please make sure integration_tests passing locally -> ✅

---------

Co-authored-by: Erick Friis <erick@langchain.dev>
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
- **Description:** add async tests, add tokenize support
- **Dependencies:**
[ibm-watsonx-ai](https://pypi.org/project/ibm-watsonx-ai/),
  - **Tag maintainer:** 

Please make sure your PR is passing linting and testing before
submitting. Run `make format`, `make lint` and `make test` to check this
locally -> ✅
Please make sure integration_tests passing locally -> ✅

---------

Co-authored-by: Erick Friis <erick@langchain.dev>
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
- **Description:** add async tests, add tokenize support
- **Dependencies:**
[ibm-watsonx-ai](https://pypi.org/project/ibm-watsonx-ai/),
  - **Tag maintainer:** 

Please make sure your PR is passing linting and testing before
submitting. Run `make format`, `make lint` and `make test` to check this
locally -> ✅
Please make sure integration_tests passing locally -> ✅

---------

Co-authored-by: Erick Friis <erick@langchain.dev>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
- **Description:** add async tests, add tokenize support
- **Dependencies:**
[ibm-watsonx-ai](https://pypi.org/project/ibm-watsonx-ai/),
  - **Tag maintainer:** 

Please make sure your PR is passing linting and testing before
submitting. Run `make format`, `make lint` and `make test` to check this
locally -> ✅
Please make sure integration_tests passing locally -> ✅

---------

Co-authored-by: Erick Friis <erick@langchain.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: models Related to LLMs or chat model modules partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants