community: Databricks SerDe uses cloudpickle instead of pickle #18607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
liangz1
changed the title
dosubot
bot
added
size:M
baskaryan
reviewed
Mar 6, 2024
| return pickle.loads(bytes.fromhex(data)) | ||
| import cloudpickle | ||
|
|
||
| return cloudpickle.loads(bytes.fromhex(data)) | ||
| except Exception as e: |
There was a problem hiding this comment.
may want to separately catch import errors so you can provide a helpful error message (e.g. "please install cloudpickle with ...")
baskaryan
approved these changes
Mar 6, 2024
dosubot
bot
added
the
lgtm
thebhulawat
pushed a commit
to thebhulawat/langchain
that referenced
this pull request
Mar 6, 2024
…langchain-ai#18607) - **Description:** Databricks SerDe uses cloudpickle instead of pickle when serializing a user-defined function transform_input_fn since pickle does not support functions defined in `__main__`, and cloudpickle supports this. - **Dependencies:** cloudpickle>=2.0.0 Added a unit test.
bechbd
pushed a commit
to bechbd/langchain
that referenced
this pull request
Mar 29, 2024
…langchain-ai#18607) - **Description:** Databricks SerDe uses cloudpickle instead of pickle when serializing a user-defined function transform_input_fn since pickle does not support functions defined in `__main__`, and cloudpickle supports this. - **Dependencies:** cloudpickle>=2.0.0 Added a unit test.
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…langchain-ai#18607) - **Description:** Databricks SerDe uses cloudpickle instead of pickle when serializing a user-defined function transform_input_fn since pickle does not support functions defined in `__main__`, and cloudpickle supports this. - **Dependencies:** cloudpickle>=2.0.0 Added a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__main__, and cloudpickle supports this.Added a unit test.
Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.