Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain-mongodb: include LLM caches in toplevel library import #18601

Merged
merged 1 commit into from Mar 6, 2024

Conversation

Jibola
Copy link
Contributor

@Jibola Jibola commented Mar 5, 2024

Description:

Adding langchain_mongodb.cache.MongoDBCache and langchain_mongodb.cache.MongoDBAtlasSemanticCache to the toplevel library init to allow for langchain_mongodb.MongoDBCache and langchain_mongodb.MongoDBAtlasSemanticCache as import options

Dependencies:

None

Twitter handle:

@mongodb

  • Add tests and docs:

    • tests/unit_tests/test_imports.py handles test check
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

cc: @ShaneHarvey, @blink1073, @NoahStapp, @caseyclements

@efriis efriis added the partner label Mar 5, 2024
@efriis efriis self-assigned this Mar 5, 2024
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 7:51pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🔌: mongo Primarily related to Mongo integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 5, 2024
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 6, 2024
@efriis efriis merged commit 8bc347c into langchain-ai:master Mar 6, 2024
20 checks passed
thebhulawat pushed a commit to thebhulawat/langchain that referenced this pull request Mar 6, 2024
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: mongo Primarily related to Mongo integrations partner size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants