core[patch]: deprecate hwchase17/langchain-hub, address path traversal (CVE-2024-28088) #18600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:S
efriis
changed the title
hwchase17
approved these changes
Mar 5, 2024
dosubot
bot
added
the
lgtm
|
Hi! Thank for deprecating this functionality. Would you also please be so kind to change my report from "informational" to "accepted" on Huntr? That way I get the proper remuneration. |
efriis
deleted the
erick/core-patch-deprecate-langchainhub-address-path-traversal
branch
thebhulawat
pushed a commit
to thebhulawat/langchain
that referenced
this pull request
Mar 6, 2024
langchain-ai#18600) Deprecates the old langchain-hub repository. Does *not* deprecate the new https://smith.langchain.com/hub @PinkDraconian has correctly raised that in the event someone is loading unsanitized user input into the `try_load_from_hub` function, they have the ability to load files from other locations in github than the hwchase17/langchain-hub repository. This PR adds some more path checking to that function and deprecates the functionality in favor of the hub built into LangSmith.
|
Address CVE: 2024-28088 |
eyurtsev
changed the title
|
@PinkDraconian we've contacted Huntr to change the status of your report, and will assess it today to assign a proper CVSS score. Going forward we ask that if you disagree with a decision and have a good argument for that please reach out to security@langchain.dev prior to filing the CVE, so we can discuss. Filing the CVE effectively blocks users from being able to deploy their applications, without an option to upgrade to get a security patch, and in this case it's dubious that the code actually poses any risk to users. |
|
My apologies for any inconvenience caused there. I will definitely take that advice for the future. |
bechbd
pushed a commit
to bechbd/langchain
that referenced
this pull request
Mar 29, 2024
langchain-ai#18600) Deprecates the old langchain-hub repository. Does *not* deprecate the new https://smith.langchain.com/hub @PinkDraconian has correctly raised that in the event someone is loading unsanitized user input into the `try_load_from_hub` function, they have the ability to load files from other locations in github than the hwchase17/langchain-hub repository. This PR adds some more path checking to that function and deprecates the functionality in favor of the hub built into LangSmith.
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
langchain-ai#18600) Deprecates the old langchain-hub repository. Does *not* deprecate the new https://smith.langchain.com/hub @PinkDraconian has correctly raised that in the event someone is loading unsanitized user input into the `try_load_from_hub` function, they have the ability to load files from other locations in github than the hwchase17/langchain-hub repository. This PR adds some more path checking to that function and deprecates the functionality in favor of the hub built into LangSmith.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the old langchain-hub repository. Does not deprecate the new https://smith.langchain.com/hub
@PinkDraconian has correctly raised that in the event someone is loading unsanitized user input into the
try_load_from_hubfunction, they have the ability to load files from other locations in github than the hwchase17/langchain-hub repository.This PR adds some more path checking to that function and deprecates the functionality in favor of the hub built into LangSmith.