New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain-mongodb: add unit tests for MongoDBChatMessageHistory #18599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Mar 5, 2024
dosubot
bot
added
🔌: mongo
Primarily related to Mongo integrations
🤖:improvement
Medium size change to existing code to handle new use-cases
labels
Mar 5, 2024
blink1073
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hwchase17
approved these changes
Mar 5, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Mar 5, 2024
thebhulawat
pushed a commit
to thebhulawat/langchain
that referenced
this pull request
Mar 6, 2024
…chain-ai#18599) ## Description Adding in Unit Test variation for `MongoDBChatMessageHistory` package Follow-up to langchain-ai#18590 - [x] **Add tests and docs**: Unit test is what's being added - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/
bechbd
pushed a commit
to bechbd/langchain
that referenced
this pull request
Mar 29, 2024
…chain-ai#18599) ## Description Adding in Unit Test variation for `MongoDBChatMessageHistory` package Follow-up to langchain-ai#18590 - [x] **Add tests and docs**: Unit test is what's being added - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…chain-ai#18599) ## Description Adding in Unit Test variation for `MongoDBChatMessageHistory` package Follow-up to langchain-ai#18590 - [x] **Add tests and docs**: Unit test is what's being added - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:improvement
Medium size change to existing code to handle new use-cases
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
🔌: mongo
Primarily related to Mongo integrations
partner
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding in Unit Test variation for
MongoDBChatMessageHistory
packageFollow-up to #18590
Add tests and docs: Unit test is what's being added
Lint and test: Run
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/