Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain-mongodb: add unit tests for MongoDBChatMessageHistory #18599

Merged
merged 3 commits into from Mar 5, 2024

Conversation

Jibola
Copy link
Contributor

@Jibola Jibola commented Mar 5, 2024

Description

Adding in Unit Test variation for MongoDBChatMessageHistory package
Follow-up to #18590

  • Add tests and docs: Unit test is what's being added

  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

@efriis efriis added the partner label Mar 5, 2024
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 7:41pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 5, 2024
@efriis efriis self-assigned this Mar 5, 2024
@dosubot dosubot bot added 🔌: mongo Primarily related to Mongo integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 5, 2024
@Jibola
Copy link
Contributor Author

Jibola commented Mar 5, 2024

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 5, 2024
@hwchase17 hwchase17 merged commit fc35262 into langchain-ai:master Mar 5, 2024
20 checks passed
thebhulawat pushed a commit to thebhulawat/langchain that referenced this pull request Mar 6, 2024
…chain-ai#18599)

## Description
Adding in Unit Test variation for `MongoDBChatMessageHistory` package
Follow-up to langchain-ai#18590 

- [x] **Add tests and docs**: Unit test is what's being added
  

- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
…chain-ai#18599)

## Description
Adding in Unit Test variation for `MongoDBChatMessageHistory` package
Follow-up to langchain-ai#18590 

- [x] **Add tests and docs**: Unit test is what's being added
  

- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
…chain-ai#18599)

## Description
Adding in Unit Test variation for `MongoDBChatMessageHistory` package
Follow-up to langchain-ai#18590 

- [x] **Add tests and docs**: Unit test is what's being added
  

- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: mongo Primarily related to Mongo integrations partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants