Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add precedence for input params over env variables in neo4j integration #18581

Merged
merged 4 commits into from Mar 5, 2024
Merged

Add precedence for input params over env variables in neo4j integration #18581

merged 4 commits into from Mar 5, 2024

Conversation

tomasonjo
Copy link
Contributor

@tomasonjo tomasonjo commented Mar 5, 2024 •
edited

input parameters take precedence over env variables

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 5, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 4:06pm

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🔌: neo4j Primarily related to Neo4j integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 5, 2024
@tomasonjo tomasonjo changed the title Add precedence for input params or env variables in neo4j integration Add precedence for input params over env variables in neo4j integration Mar 5, 2024
@tomasonjo tomasonjo closed this Mar 5, 2024
@tomasonjo tomasonjo reopened this Mar 5, 2024
jexp
jexp approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jexp jexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this so quickly, it caused quite a number of issues that invisible env variables took precedence over explicit parameters passed in to the constructors.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 5, 2024
@hwchase17 hwchase17 merged commit 3532488 into langchain-ai:master Mar 5, 2024
60 of 67 checks passed
thebhulawat pushed a commit to thebhulawat/langchain that referenced this pull request Mar 6, 2024
@tomasonjo @thebhulawat
Add precedence for input params over env variables in neo4j integrati…
5214f90 
…on (langchain-ai#18581)

input parameters take precedence over env variables
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
@tomasonjo
Add precedence for input params over env variables in neo4j integrati…
5c86289 
…on (langchain-ai#18581)

input parameters take precedence over env variables
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@tomasonjo @gkorland
Add precedence for input params over env variables in neo4j integrati…
122fa0b 
…on (langchain-ai#18581)

input parameters take precedence over env variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jexp jexp jexp approved these changes

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: neo4j Primarily related to Neo4j integrations size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomasonjo @jexp @hwchase17