Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Improve amadeus tool and doc #18509

Merged

Conversation

caidwang
Copy link
Contributor

@caidwang caidwang commented Mar 4, 2024

Description:

This pull request addresses two key improvements to the langchain repository:

Fix for Crash in Flight Search Interface:

Previously, the code would crash when encountering a failure scenario in the flight ticket search interface. This PR resolves this issue by implementing a fix to handle such scenarios gracefully. Now, the code handles failures in the flight search interface without crashing, ensuring smoother operation.

Documentation Update for Amadeus Toolkit:

Prior to this update, examples provided in the documentation for the Amadeus Toolkit were unable to run correctly due to outdated information. This PR includes an update to the documentation, ensuring that all examples can now be executed successfully. With this update, users can effectively utilize the Amadeus Toolkit with accurate and functioning examples.
These changes aim to enhance the reliability and usability of the langchain repository by addressing issues related to error handling and ensuring that documentation remains up-to-date and actionable.

Issue: #17375

Twitter Handle: SingletonYxx

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 4, 2024
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview Mar 4, 2024 3:11pm

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Mar 4, 2024
@caidwang
Copy link
Contributor Author

caidwang commented Mar 4, 2024

While learning to use the Amadeus toolkit with examples, I encountered two major issues:

  • The example provided in the documentation, as mentioned in issue Amadeus searchflight not working #17375 regarding Amadeus flight search not working, utilizes the ReActSingleInputOutputParser, which fails to parse the request of tools.

  • The examples in the documentation relied on the tool description, which inconsistently produced outputs that matched the required parameter names for the API.

To address these issues, enhancements have been made to the relevant codebase. Specifically, during the execution of all examples, it was noted that the toolkit did not effectively handle scenarios where API calls failed. Consequently, improvements have been implemented to handle API call failures more effectively.

@caidwang
Copy link
Contributor Author

caidwang commented Mar 5, 2024

Hello @hwchase17 @baskaryan , could you please take a moment to have a glance?

Many Thanks!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 6, 2024
@baskaryan baskaryan merged commit dc81dba into langchain-ai:master Mar 6, 2024
61 checks passed
thebhulawat pushed a commit to thebhulawat/langchain that referenced this pull request Mar 6, 2024
Description:

This pull request addresses two key improvements to the langchain
repository:

**Fix for Crash in Flight Search Interface**:

Previously, the code would crash when encountering a failure scenario in
the flight ticket search interface. This PR resolves this issue by
implementing a fix to handle such scenarios gracefully. Now, the code
handles failures in the flight search interface without crashing,
ensuring smoother operation.

**Documentation Update for Amadeus Toolkit**:

Prior to this update, examples provided in the documentation for the
Amadeus Toolkit were unable to run correctly due to outdated
information. This PR includes an update to the documentation, ensuring
that all examples can now be executed successfully. With this update,
users can effectively utilize the Amadeus Toolkit with accurate and
functioning examples.
These changes aim to enhance the reliability and usability of the
langchain repository by addressing issues related to error handling and
ensuring that documentation remains up-to-date and actionable.

Issue: langchain-ai#17375

Twitter Handle: SingletonYxx
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
Description:

This pull request addresses two key improvements to the langchain
repository:

**Fix for Crash in Flight Search Interface**:

Previously, the code would crash when encountering a failure scenario in
the flight ticket search interface. This PR resolves this issue by
implementing a fix to handle such scenarios gracefully. Now, the code
handles failures in the flight search interface without crashing,
ensuring smoother operation.

**Documentation Update for Amadeus Toolkit**:

Prior to this update, examples provided in the documentation for the
Amadeus Toolkit were unable to run correctly due to outdated
information. This PR includes an update to the documentation, ensuring
that all examples can now be executed successfully. With this update,
users can effectively utilize the Amadeus Toolkit with accurate and
functioning examples.
These changes aim to enhance the reliability and usability of the
langchain repository by addressing issues related to error handling and
ensuring that documentation remains up-to-date and actionable.

Issue: langchain-ai#17375

Twitter Handle: SingletonYxx
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
Description:

This pull request addresses two key improvements to the langchain
repository:

**Fix for Crash in Flight Search Interface**:

Previously, the code would crash when encountering a failure scenario in
the flight ticket search interface. This PR resolves this issue by
implementing a fix to handle such scenarios gracefully. Now, the code
handles failures in the flight search interface without crashing,
ensuring smoother operation.

**Documentation Update for Amadeus Toolkit**:

Prior to this update, examples provided in the documentation for the
Amadeus Toolkit were unable to run correctly due to outdated
information. This PR includes an update to the documentation, ensuring
that all examples can now be executed successfully. With this update,
users can effectively utilize the Amadeus Toolkit with accurate and
functioning examples.
These changes aim to enhance the reliability and usability of the
langchain repository by addressing issues related to error handling and
ensuring that documentation remains up-to-date and actionable.

Issue: langchain-ai#17375

Twitter Handle: SingletonYxx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants