Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix link and missing package #18405

Merged
merged 10 commits into from Mar 5, 2024
Merged

Conversation

rodrigo-f-nogueira
Copy link
Contributor

Issue: fix broken links and missing package on colab example

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 1, 2024
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 10:31pm

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Mar 1, 2024
Copy link
Collaborator

@leo-gan leo-gan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@rodrigo-f-nogueira Thank you for fixing it!

@leo-gan leo-gan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 1, 2024
@rodrigo-f-nogueira
Copy link
Contributor Author

Hi @leo-gan, is there something with the code here? I'm asking because I saw multiple failures in the CI jobs but no error shows in this PR

@leo-gan
Copy link
Collaborator

leo-gan commented Mar 5, 2024

@rodrigo-f-nogueira Probably, errors are not related to your code. My guess, it is something with the last changes in CI/CD workflows.

@rodrigo-f-nogueira
Copy link
Contributor Author

@leo-gan, it is all good now, right?

@leo-gan
Copy link
Collaborator

leo-gan commented Mar 5, 2024

@efriis Can you, please, merge it? Thanks
CC @rodrigo-f-nogueira

@baskaryan baskaryan merged commit f4bb33b into langchain-ai:master Mar 5, 2024
11 checks passed
thebhulawat pushed a commit to thebhulawat/langchain that referenced this pull request Mar 6, 2024
**Issue:** fix broken links and missing package on colab example
@rodrigo-f-nogueira rodrigo-f-nogueira deleted the fix-link branch March 15, 2024 09:58
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
**Issue:** fix broken links and missing package on colab example
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
**Issue:** fix broken links and missing package on colab example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants