New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add retriever self_query and score_threshold in DingoDB #18106
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2019c47
to
8d370a6
Compare
8d370a6
to
b3ae7d3
Compare
b3ae7d3
to
28eb1a7
Compare
bee5992
to
03bb415
Compare
@baskaryan Can you help me review it? |
) | ||
|
||
|
||
class DingoDBTranslator(Visitor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coudl we add some unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, I added some unit tests
…e_threshold in DingoDB (langchain-ai#18106)
…e_threshold in DingoDB (langchain-ai#18106)
…e_threshold in DingoDB (langchain-ai#18106)
Thank you for contributing to LangChain!
PR title: "package: description"
PR message: Delete this entire checklist and replace with
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrations
directory.Lint and test: Run
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.