New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: API Reference builder bug fix #17890
Merged
eyurtsev
merged 1 commit into
langchain-ai:master
from
leo-gan:api-references-only-public-elements-bug-fix
Feb 21, 2024
Merged
docs: API Reference builder bug fix #17890
eyurtsev
merged 1 commit into
langchain-ai:master
from
leo-gan:api-references-only-public-elements-bug-fix
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
labels
Feb 21, 2024
leo-gan
added
the
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
label
Feb 21, 2024
eyurtsev
approved these changes
Feb 21, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Feb 21, 2024
@eyurtsev Thanks! Eugene, could you, please, build the API Ref to check if this fix works? I can not do this locally now (in process of debugging the problem with this build) |
k8si
pushed a commit
to Mozilla-Ocho/langchain
that referenced
this pull request
Feb 22, 2024
Issue in the API Reference: If the `Classes` of `Functions` section is empty, it still shown in API Reference. Here is an [example](https://api.python.langchain.com/en/latest/core_api_reference.html#module-langchain_core.agents) where `Functions` table is empty but still presented. It happens only if this section has only the "private" members (with names started with '_'). Those members are not shown but the whole member section (empty) is shown.
al1p
pushed a commit
to al1p/langchain
that referenced
this pull request
Feb 27, 2024
Issue in the API Reference: If the `Classes` of `Functions` section is empty, it still shown in API Reference. Here is an [example](https://api.python.langchain.com/en/latest/core_api_reference.html#module-langchain_core.agents) where `Functions` table is empty but still presented. It happens only if this section has only the "private" members (with names started with '_'). Those members are not shown but the whole member section (empty) is shown.
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
Issue in the API Reference: If the `Classes` of `Functions` section is empty, it still shown in API Reference. Here is an [example](https://api.python.langchain.com/en/latest/core_api_reference.html#module-langchain_core.agents) where `Functions` table is empty but still presented. It happens only if this section has only the "private" members (with names started with '_'). Those members are not shown but the whole member section (empty) is shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue in the API Reference:
If the
Classes
ofFunctions
section is empty, it still shown in API Reference. Here is an example whereFunctions
table is empty but still presented.It happens only if this section has only the "private" members (with names started with '_'). Those members are not shown but the whole member section (empty) is shown.