Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SCANN index in default search params #17889

Merged
merged 1 commit into from Feb 21, 2024

Conversation

rgupta2508
Copy link
Contributor

@rgupta2508 rgupta2508 commented Feb 21, 2024

Thank you for contributing to LangChain!

This will enable users to add data in same collection for index type SCANN for milvus

  • PR title: "package: description"

    • Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
    • Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!
  • Add tests and docs: If you're adding a new integration, please include

    1. a test for the integration, preferably unit tests that do not rely on network access,
    2. an example notebook showing its use. It lives in docs/docs/integrations directory.
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2024 8:34pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🔌: milvus Primarily related to Milvus vector store integration 🤖:improvement Medium size change to existing code to handle new use-cases labels Feb 21, 2024
@baskaryan baskaryan merged commit 3acd0c7 into langchain-ai:master Feb 21, 2024
58 checks passed
k8si pushed a commit to Mozilla-Ocho/langchain that referenced this pull request Feb 22, 2024
…in-ai#17889)

This will enable users to add data in same collection for index type
SCANN for milvus
al1p pushed a commit to al1p/langchain that referenced this pull request Feb 27, 2024
…in-ai#17889)

This will enable users to add data in same collection for index type
SCANN for milvus
haydeniw pushed a commit to haydeniw/langchain that referenced this pull request Feb 27, 2024
…in-ai#17889)

This will enable users to add data in same collection for index type
SCANN for milvus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases 🔌: milvus Primarily related to Milvus vector store integration size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants