community[patch]: add missing chunk parameter for _stream/_astream #17807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mackong
commented
Feb 20, 2024
mackong
commented
- Description: Add missing chunk parameter for _stream/_astream for some chat models, make all chat models in a consistent behaviour.
- Issue: N/A
- Dependencies: N/A
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
eyurtsev
changed the title
eyurtsev
approved these changes
Feb 20, 2024
dosubot
bot
added
the
lgtm
|
@mackong thank you very much for the patch! There's another issue with most of these models. They should be calling the callback prior to yielding the chunk rather than after yielding the chunk. If you have interest, we'd appreciate another PR for that as well :) |
|
@mackong if your'e able to resolve the linting error, we can merge right away |
mackong
force-pushed
the
add-missing-chunk
branch
from
5ebdba2
to
b945ab3
Compare
Fixed. |
OK, I'll fix it in another PR. |
eyurtsev
approved these changes
Feb 21, 2024
|
merge when tests pass |
k8si
pushed a commit
to Mozilla-Ocho/langchain
that referenced
this pull request
Feb 22, 2024
…angchain-ai#17807) - Description: Add missing chunk parameter for _stream/_astream for some chat models, make all chat models in a consistent behaviour. - Issue: N/A - Dependencies: N/A
al1p
pushed a commit
to al1p/langchain
that referenced
this pull request
Feb 27, 2024
…angchain-ai#17807) - Description: Add missing chunk parameter for _stream/_astream for some chat models, make all chat models in a consistent behaviour. - Issue: N/A - Dependencies: N/A
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
…angchain-ai#17807) - Description: Add missing chunk parameter for _stream/_astream for some chat models, make all chat models in a consistent behaviour. - Issue: N/A - Dependencies: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.