Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Fix AstraDBCache docstrings #17802

Merged
merged 2 commits into from Feb 20, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Feb 20, 2024

No description provided.

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain 猬滐笍 Ignored (Inspect) Visit Preview Feb 20, 2024 4:10pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 馃攲: astradb Primarily related to AstraDB integrations 馃:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Feb 20, 2024
@@ -1374,6 +1374,22 @@ class AstraDBCache(BaseCache):
- prompt, a string
- llm_string, a deterministic str representation of the model parameters.
(needed to prevent same-prompt-different-model collisions)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cbornet, we follow google style documentation https://google.github.io/styleguide/pyguide.html#384-classes

Class level documentation is for documenting public attributes. I suspect that none of these attributes are meant to be used as public attributes, so documenting them only on the init makes the most sense to me.

What's the reason for making this change?

Copy link
Collaborator Author

@cbornet cbornet Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, Sphinx default setup doesn't document the __init__ and vice-versa so it's a common usage to put the args in the class docstring.
If we look at https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html#example-google (see classes ExampleError and ExampleClass) both are allowed:

        The __init__ method may be documented in either the class level
        docstring, or as a docstring on the __init__ method itself.

        Either form is acceptable, but the two should not be mixed. Choose one
        convention to document the __init__ method and be consistent with it.

Also PyCharm will use the class doc if it doesn't find an __init__ doc. It's then nice to put a lot of info into the class and get that info when hovering a class instanciation.

That said, I see that the LangCHain setup does document the __init__ method separately and copies its content to the class doc (autoclass_content = "both").
So probably the best is to put most useful info into the __init__ and very basic headline or nothing in the class. This way, both PyCharm and LC docs will be happy.
I'll update the PRs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. PTAL.

Copy link
Collaborator

@eyurtsev eyurtsev Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those following from home: https://en.wiktionary.org/wiki/PTAL

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 20, 2024
@eyurtsev eyurtsev merged commit b13e52b into langchain-ai:master Feb 20, 2024
58 checks passed
@cbornet cbornet deleted the astra-cache-docstring branch February 20, 2024 16:42
al1p pushed a commit to al1p/langchain that referenced this pull request Feb 27, 2024
haydeniw pushed a commit to haydeniw/langchain that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃攲: astradb Primarily related to AstraDB integrations 馃:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants