Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Add SparkLLM Text Embedding Model and SparkLLM introduction #17573

Merged
merged 15 commits into from Feb 20, 2024

Conversation

liugddx
Copy link
Contributor

@liugddx liugddx commented Feb 15, 2024

Thank you for contributing to LangChain!

Checklist:

  • PR title: Please title your PR "package: description", where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"
  • PR message: Delete this entire template message and replace it with the following bulleted list
  • Pass lint and test: Run make format, make lint and make test from the root of the package(s) you've modified to check that you're passing lint and testing. See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/
  • Add tests and docs: If you're adding a new integration, please include
    1. a test for the integration, preferably unit tests that do not rely on network access,
    2. an example notebook showing its use. It lives in docs/docs/integrations directory.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 15, 2024
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 8:40am

@dosubot dosubot bot added the 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Feb 15, 2024
@liugddx
Copy link
Contributor Author

liugddx commented Feb 16, 2024

@baskaryan PTAL, thanks.

@liugddx
Copy link
Contributor Author

liugddx commented Feb 17, 2024

@efriis @eyurtsev @hwchase17 kindly ping.

@liugddx
Copy link
Contributor Author

liugddx commented Feb 19, 2024

@baskaryan Can you help me with the ci problem?

@baskaryan
Copy link
Collaborator

@baskaryan Can you help me with the ci problem?

looks like there's a number of lines that are too long https://github.com/langchain-ai/langchain/actions/runs/7960221654/job/21728761889?pr=17573. To check the fix you can run linting locally with

cd libs/community
poetry install --with lint,typing
make format
make lint

@liugddx
Copy link
Contributor Author

liugddx commented Feb 20, 2024

@baskaryan Can you help me with the ci problem?

looks like there's a number of lines that are too long https://github.com/langchain-ai/langchain/actions/runs/7960221654/job/21728761889?pr=17573. To check the fix you can run linting locally with

cd libs/community
poetry install --with lint,typing
make format
make lint

Thank you @baskaryan, this helps me a lot.

@liugddx
Copy link
Contributor Author

liugddx commented Feb 20, 2024

@baskaryan Can you help me with the ci problem?

looks like there's a number of lines that are too long https://github.com/langchain-ai/langchain/actions/runs/7960221654/job/21728761889?pr=17573. To check the fix you can run linting locally with

cd libs/community
poetry install --with lint,typing
make format
make lint

Thank you @baskaryan, this helps me a lot.

Another question, I executed make format and make lint and got an error. Can it automatically format the code?

image

@liugddx
Copy link
Contributor Author

liugddx commented Feb 20, 2024

@baskaryan PTAL, thanks.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 20, 2024
@liugddx
Copy link
Contributor Author

liugddx commented Feb 20, 2024

Can you help me merge this pr? @baskaryan

@baskaryan baskaryan merged commit 3ba1cb8 into langchain-ai:master Feb 20, 2024
61 checks passed
k8si pushed a commit to Mozilla-Ocho/langchain that referenced this pull request Feb 22, 2024
al1p pushed a commit to al1p/langchain that referenced this pull request Feb 27, 2024
haydeniw pushed a commit to haydeniw/langchain that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants