langchain-mongodb: Add MongoDB LLM Cache #17470

Jibola · 2024-02-13T18:17:35Z

Description

Description: Adding MongoDB LLM Caching Layer abstraction
Issue: N/A
Dependencies: None
Twitter handle: @mongodb

Checklist:

PR title: Please title your PR "package: description", where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
- Example: "community: add foobar LLM"
PR Message (above)
Pass lint and test: Run make format, make lint and make test from the root of the package(s) you've modified to check that you're passing lint and testing. See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/
Add tests and docs: If you're adding a new integration, please include
1. a test for the integration, preferably unit tests that do not rely on network access,
2. an example notebook showing its use. It lives in docs/docs/integrations directory.

Additional guidelines:

Make sure optional dependencies are imported within a function.
Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
Most PRs should not touch more than one package.
Changes should be backwards compatible.
If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of @baskaryan, @efriis, @eyurtsev, @hwchase17.

vercel · 2024-02-13T18:17:40Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchain	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 4, 2024 9:03pm

libs/community/langchain_community/cache.py

libs/community/langchain_community/vectorstores/mongodb_atlas.py

Jibola · 2024-02-15T19:47:14Z

cc: @ShaneHarvey @blink1073 @NoahStapp @caseyclements

ShaneHarvey · 2024-02-15T19:53:38Z

libs/community/langchain_community/cache.py

+            return self.lookup(prompt, llm_string) == return_val
+
+        if wait:
+            _wait_until(is_value_stored, return_val)


This shouldn't raise AssertionError on a timeout. Some kind of timeout error would be more appropriate.

ShaneHarvey · 2024-02-15T19:58:12Z

libs/community/langchain_community/cache.py

+        prompt: str,
+        llm_string: str,
+        return_val: RETURN_VAL_TYPE,
+        wait_until_ready: Optional[bool] = None,


Should be bool = False

Can we think of any other names besides wait_until_ready?

how about ensure_indexed?
or wait_until_indexed?

I like wait_until_indexed

Jibola · 2024-02-15T21:15:41Z

cc: @prakul

efriis

Jib will move to partner package.

Some comments

can we add some unit tests
can we add docs to the caching page https://python.langchain.com/docs/modules/model_io/chat/chat_model_caching

Jibola · 2024-02-20T15:30:11Z

Jib will move to partner package.

Some comments

can we add some unit tests

can we add docs to the caching page https://python.langchain.com/docs/modules/model_io/chat/chat_model_caching

Yeah, I've decided I'll move these changes to the partners/mongodb-atlas once the partner-package PR is in .

## **Description** Migrate the `MongoDBChatMessageHistory` to the managed `langchain-mongodb` partner-package ## **Dependencies** None ## **Twitter handle** @mongodb ## **tests and docs** - [x] Migrate existing integration test - [x ]~ Convert existing integration test to a unit test~ Creation is out of scope for this ticket - [x ] ~Considering delaying work until #17470 merges to leverage the `MockCollection` object. ~ - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ --------- Co-authored-by: Erick Friis <erick@langchain.dev>

@baskaryan

# Description - **Description:** Adding MongoDB LLM Caching Layer abstraction - **Issue:** N/A - **Dependencies:** None - **Twitter handle:** @mongodb Checklist: - [x] PR title: Please title your PR "package: description", where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [x] PR Message (above) - [x] Pass lint and test: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified to check that you're passing lint and testing. See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/ - [ ] Add tests and docs: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @efriis, @eyurtsev, @hwchase17. --------- Co-authored-by: Jib <jib@byblack.us>

## **Description** Migrate the `MongoDBChatMessageHistory` to the managed `langchain-mongodb` partner-package ## **Dependencies** None ## **Twitter handle** @mongodb ## **tests and docs** - [x] Migrate existing integration test - [x ]~ Convert existing integration test to a unit test~ Creation is out of scope for this ticket - [x ] ~Considering delaying work until langchain-ai#17470 merges to leverage the `MockCollection` object. ~ - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ --------- Co-authored-by: Erick Friis <erick@langchain.dev>

@baskaryan

# Description - **Description:** Adding MongoDB LLM Caching Layer abstraction - **Issue:** N/A - **Dependencies:** None - **Twitter handle:** @mongodb Checklist: - [x] PR title: Please title your PR "package: description", where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [x] PR Message (above) - [x] Pass lint and test: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified to check that you're passing lint and testing. See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/ - [ ] Add tests and docs: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @efriis, @eyurtsev, @hwchase17. --------- Co-authored-by: Jib <jib@byblack.us>

## **Description** Migrate the `MongoDBChatMessageHistory` to the managed `langchain-mongodb` partner-package ## **Dependencies** None ## **Twitter handle** @mongodb ## **tests and docs** - [x] Migrate existing integration test - [x ]~ Convert existing integration test to a unit test~ Creation is out of scope for this ticket - [x ] ~Considering delaying work until langchain-ai#17470 merges to leverage the `MockCollection` object. ~ - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ --------- Co-authored-by: Erick Friis <erick@langchain.dev>

@baskaryan

# Description - **Description:** Adding MongoDB LLM Caching Layer abstraction - **Issue:** N/A - **Dependencies:** None - **Twitter handle:** @mongodb Checklist: - [x] PR title: Please title your PR "package: description", where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [x] PR Message (above) - [x] Pass lint and test: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified to check that you're passing lint and testing. See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/ - [ ] Add tests and docs: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of @baskaryan, @efriis, @eyurtsev, @hwchase17. --------- Co-authored-by: Jib <jib@byblack.us>

## **Description** Migrate the `MongoDBChatMessageHistory` to the managed `langchain-mongodb` partner-package ## **Dependencies** None ## **Twitter handle** @mongodb ## **tests and docs** - [x] Migrate existing integration test - [x ]~ Convert existing integration test to a unit test~ Creation is out of scope for this ticket - [x ] ~Considering delaying work until langchain-ai#17470 merges to leverage the `MockCollection` object. ~ - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ --------- Co-authored-by: Erick Friis <erick@langchain.dev>

Jibola added 2 commits February 13, 2024 12:57

MongoDBAtlas LLM Caching Objects

576d1d0

Merge branch 'master' into mongodb-llm-cache

1288aa3

Jibola and others added 2 commits February 13, 2024 13:17

Merge branch 'master' into mongodb-llm-cache

abca853

format

7d49586

baskaryan assigned efriis Feb 13, 2024

Jibola added 2 commits February 13, 2024 14:20

lints and formatting

a395cc9

added docstrings

e67aa22

Jibola commented Feb 14, 2024

View reviewed changes

libs/community/langchain_community/cache.py Outdated Show resolved Hide resolved

Jibola commented Feb 14, 2024

View reviewed changes

libs/community/langchain_community/vectorstores/mongodb_atlas.py Outdated Show resolved Hide resolved

Remove print and whitespace

74dc9ce

Jibola marked this pull request as ready for review February 14, 2024 14:28

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: memory Related to memory module 🤖:improvement Medium size change to existing code to handle new use-cases labels Feb 14, 2024

Merge branch 'master' into mongodb-llm-cache

75c88f3

ShaneHarvey suggested changes Feb 15, 2024

View reviewed changes

efriis reviewed Feb 16, 2024

View reviewed changes

baskaryan added needs test PR needs to be updated with tests needs documentation PR needs to be updated with documentation labels Feb 18, 2024

Jib added 3 commits March 1, 2024 12:33

fix merge conflicts

52e9bd6

fix merge conflicts(2)

c50d93a

make format on mongodb partners page

8b601d1

efriis added the partner label Mar 1, 2024

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 1, 2024

Jibola changed the title ~~langchain_community: Add MongoDB LLM Cache~~ langchain-mongodb: Add MongoDB LLM Cache Mar 3, 2024

Jib and others added 10 commits March 4, 2024 10:07

lints; formats; consolidation of utility functions

f22ba76

removed cache imports

3bb4724

added unit tests for the cache

b9ff1fb

fix lint

2cca085

change langchain -> langchain_core

eb5afde

do the same in test_cache

b990d02

do the same in integration_test/test_cache

bd65384

fix typing check

0b16a38

fix List on typing test

df92592

used 3.8 compatible typing on test_cache

a551cd5

vercel bot deployed to Preview March 4, 2024 20:01 View deployment

added caching documentation and included a simple local cache

ab453a6

vercel bot deployed to Preview March 4, 2024 21:03 View deployment

Jibola requested review from efriis, blink1073 and ShaneHarvey March 5, 2024 16:33

Jibola mentioned this pull request Mar 5, 2024

langchain-mongodb: Migrate MongoDBChatMessageHistory #18590

Merged

2 tasks

efriis approved these changes Mar 5, 2024

View reviewed changes

dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 5, 2024

efriis merged commit f92f7d2 into langchain-ai:master Mar 5, 2024
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

langchain-mongodb: Add MongoDB LLM Cache #17470

langchain-mongodb: Add MongoDB LLM Cache #17470

Jibola commented Feb 13, 2024 •

edited

vercel bot commented Feb 13, 2024 •

edited

Jibola commented Feb 15, 2024 •

edited

ShaneHarvey Feb 15, 2024

ShaneHarvey Feb 15, 2024

Jibola Feb 15, 2024

blink1073 Feb 15, 2024

Jibola commented Feb 15, 2024

efriis left a comment

Jibola commented Feb 20, 2024

langchain-mongodb: Add MongoDB LLM Cache #17470

langchain-mongodb: Add MongoDB LLM Cache #17470

Conversation

Jibola commented Feb 13, 2024 • edited

Description

vercel bot commented Feb 13, 2024 • edited

Jibola commented Feb 15, 2024 • edited

ShaneHarvey Feb 15, 2024

Choose a reason for hiding this comment

ShaneHarvey Feb 15, 2024

Choose a reason for hiding this comment

Jibola Feb 15, 2024

Choose a reason for hiding this comment

blink1073 Feb 15, 2024

Choose a reason for hiding this comment

Jibola commented Feb 15, 2024

efriis left a comment

Choose a reason for hiding this comment

Jibola commented Feb 20, 2024

Jibola commented Feb 13, 2024 •

edited

vercel bot commented Feb 13, 2024 •

edited

Jibola commented Feb 15, 2024 •

edited