Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partners/openai: fix depracation errors of pydantic's .dict() function (reopen #16629) #17404

Merged
merged 7 commits into from Feb 21, 2024

Conversation

SavvasMohito
Copy link
Contributor

I am re-opening #16629 as I closed it accidentally. The commit matches the code of the previous PR, but we could improve it further based on the discussion in #16629. Thanks

@efriis efriis added the partner label Feb 12, 2024
@efriis efriis self-assigned this Feb 12, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 12, 2024
Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 7:08pm

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:improvement Medium size change to existing code to handle new use-cases 🔌: openai Primarily related to OpenAI integrations labels Feb 12, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 12, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you linking prior discussion!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 12, 2024
@efriis efriis merged commit 691ff67 into langchain-ai:master Feb 21, 2024
18 checks passed
k8si pushed a commit to Mozilla-Ocho/langchain that referenced this pull request Feb 22, 2024
al1p pushed a commit to al1p/langchain that referenced this pull request Feb 27, 2024
haydeniw pushed a commit to haydeniw/langchain that referenced this pull request Feb 27, 2024
…n (reopen langchain-ai#16629) (langchain-ai#17404)



---------

Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: models Related to LLMs or chat model modules 🔌: openai Primarily related to OpenAI integrations partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants