Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neo4j-generation template: replace openai legacy function, return proper chainable #16436

Closed
wants to merge 4 commits into from

Conversation

tewnut
Copy link

@tewnut tewnut commented Jan 23, 2024

  • create_structured_output_chain is a legacy function, replaced with create_structured_output_runnable
  • the chain returned is an invalid function, use proper LCEL.
  • the prompt is kept intact, only change how allow_nodes and allow_rels are fed into the prompt.
  • make add_graph_documents a RunnableLamda

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 9:19pm

@efriis efriis self-assigned this Jan 23, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: lcel Related to LangChain Expression Language (LCEL) 🤖:refactor A large refactor of a feature(s) or restructuring of many files labels Jan 23, 2024
@hwchase17 hwchase17 closed this Jan 30, 2024
@baskaryan baskaryan reopened this Jan 30, 2024
@baskaryan baskaryan closed this Jan 30, 2024
@baskaryan baskaryan reopened this Jan 30, 2024
@efriis
Copy link
Member

efriis commented Mar 11, 2024

cc @tomasonjo

@baskaryan
Copy link
Collaborator

closing in favor of #19024 which uses LLMGraphTransformer. appreciate the contribution anyways @tewnut!

@baskaryan baskaryan closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: lcel Related to LangChain Expression Language (LCEL) 🤖:refactor A large refactor of a feature(s) or restructuring of many files size:L This PR changes 100-499 lines, ignoring generated files. template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants