Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #12978

Closed
Closed

Conversation

wewebber-merlin
Copy link
Contributor

@wewebber-merlin wewebber-merlin commented Nov 7, 2023

  • Description: Add "streaming" parameter to ChatFireworks client.
  • Dependencies: none.

Functionality is similar to that in ChatOpenAI and several other chat models. If "streaming=True" is set, then calls to _generate are forwarded to _stream, and wrapped with _generate_from_stream.

Integration tests added and pass.

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:41pm

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:improvement Medium size change to existing code to handle new use-cases labels Nov 7, 2023
@baskaryan
Copy link
Collaborator

believe this was resolved in #17694

@baskaryan baskaryan closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases Ɑ: models Related to LLMs or chat model modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants