Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prompt validation opt-in #11973

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Make prompt validation opt-in #11973

merged 3 commits into from
Oct 18, 2023

Conversation

nfcampos
Copy link
Collaborator

By default replace input_variables with the correct value

By default replace input_variables with the correct value
@nfcampos nfcampos requested a review from eyurtsev October 18, 2023 09:46
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 3:02pm

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:improvement Medium size change to existing code to handle new use-cases labels Oct 18, 2023
@eyurtsev eyurtsev self-assigned this Oct 18, 2023
@@ -99,6 +100,20 @@ def check_valid_template(
)


def get_template_variables(template: str, template_format: str) -> List[str]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that verifies that repeated variables only appear once for each template format?

| set(values["prefix"].input_variables if values["prefix"] else [])
- set(values["partial_variables"])
)
print(values["input_variables"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print

Base automatically changed from nc/fix-few-shot-dict to master October 18, 2023 15:28
@nfcampos nfcampos merged commit 6bd9c1d into master Oct 18, 2023
@nfcampos nfcampos deleted the nc/prompt-validation-optin branch October 18, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases Ɑ: models Related to LLMs or chat model modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants