GCSFileLoader retrieve blob custom metadata and append to document metadata #11066
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bharatl
commented
Sep 26, 2023
bharatl
commented
- Description: GCSFileLoader retrieve blob's custom metadata and append to document's metadata
- Issue: GCSFileLoader need to read blob's metadata and populate it to documents metadata #9975,
- Tag maintainer: @baskaryan please review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
baskaryan
reviewed
Sep 28, 2023
| @@ -62,6 +62,8 @@ def load(self) -> List[Document]: | |||
| bucket = storage_client.get_bucket(self.bucket) | |||
| # Create a blob object from the filepath | |||
| blob = bucket.blob(self.blob) | |||
| # retrieve custom metadata associated with the blob | |||
| metadata = bucket.get_blob(self.blob).metadata | |||
There was a problem hiding this comment.
can we just do metadata = blob.metadata?
There was a problem hiding this comment.
@baskaryan
blob() does not actually send any request to GCS while get_blob() fetches meta-information about the blob from GCS. So metadata = blob.metadata wont fetch any meta information.
What I can think of instead of blob = bucket.blob(self.blob) we can have blob = bucket.get_blob(self.blob) and fetch metadata using blob.metadata. Your thoughts please
reference: link
There was a problem hiding this comment.
@baskaryan any thoughts
There was a problem hiding this comment.
gotcha, missed the blob vs get_blob part!
|
thanks @bharatl! |
hoanq1811
pushed a commit
to hoanq1811/langchain
that referenced
this pull request
Feb 2, 2024
…tadata (langchain-ai#11066) - **Description:** GCSFileLoader retrieve blob's custom metadata and append to document's metadata - **Issue:** langchain-ai#9975, - **Tag maintainer:** @baskaryan please review Co-authored-by: b0l00ib <bharat.lal@walmart.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.