Skip to content

Commit

Permalink
core[patch]: Runnable with message history to use add_messages (#17958)
Browse files Browse the repository at this point in the history
This PR updates RunnableWithMessageHistory to use add_messages which
will save on round-trips for any chat
history abstractions that implement the optimization. If the
optimization isn't
implemented, add_messages automatically invokes add_message serially.
  • Loading branch information
eyurtsev committed Feb 24, 2024
1 parent 1c1bb11 commit 68527b8
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions libs/core/langchain_core/runnables/history.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ class InMemoryHistory(BaseChatMessageHistory, BaseModel):
messages: List[BaseMessage] = Field(default_factory=list)
def add_message(self, message: BaseMessage) -> None:
\"\"\"Add a self-created message to the store\"\"\"
self.messages.append(message)
def add_messages(self, messages: List[BaseMessage]) -> None:
\"\"\"Add a list of messages to the store\"\"\"
self.messages.extend(messages)
def clear(self) -> None:
self.messages = []
Expand Down Expand Up @@ -420,7 +420,7 @@ async def _aenter_history(
return await run_in_executor(config, self._enter_history, input, config)

def _exit_history(self, run: Run, config: RunnableConfig) -> None:
hist = config["configurable"]["message_history"]
hist: BaseChatMessageHistory = config["configurable"]["message_history"]

# Get the input messages
inputs = load(run.inputs)
Expand All @@ -436,9 +436,7 @@ def _exit_history(self, run: Run, config: RunnableConfig) -> None:
# Get the output messages
output_val = load(run.outputs)
output_messages = self._get_output_messages(output_val)

for m in input_messages + output_messages:
hist.add_message(m)
hist.add_messages(input_messages + output_messages)

def _merge_configs(self, *configs: Optional[RunnableConfig]) -> RunnableConfig:
config = super()._merge_configs(*configs)
Expand Down

0 comments on commit 68527b8

Please sign in to comment.