Skip to content

Commit

Permalink
infra: update to pathspec for 'git grep' in lint check (#18178)
Browse files Browse the repository at this point in the history
**Description:** Update to the pathspec for 'git grep' in lint check in
the Makefile
**Issue:** The pathspec {docs/docs,templates,cookbook} is not handled
correctly leading to the error during 'make lint' -
"fatal: ambiguous argument '{docs/docs,templates,cookbook}': unknown
revision or path not in the working tree."
See changes made in #18058

Co-authored-by: Erick Friis <erick@langchain.dev>
  • Loading branch information
sepiatone and efriis committed Mar 1, 2024
1 parent 57c733e commit 44b33fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ lint lint_package lint_tests:
poetry run ruff docs templates cookbook
poetry run ruff format docs templates cookbook --diff
poetry run ruff --select I docs templates cookbook
git grep 'from langchain import' {docs/docs,templates,cookbook} | grep -vE 'from langchain import (hub)' && exit 1 || exit 0
git grep 'from langchain import' docs/docs templates cookbook | grep -vE 'from langchain import (hub)' && exit 1 || exit 0

format format_diff:
poetry run ruff format docs templates cookbook
Expand Down

0 comments on commit 44b33fc

Please sign in to comment.